Fix trie deleteString logic to preserve shared prefix words#3135
Open
sudheerxdev wants to merge 4 commits into
Open
Fix trie deleteString logic to preserve shared prefix words#3135sudheerxdev wants to merge 4 commits into
sudheerxdev wants to merge 4 commits into
Conversation
- Only prune child nodes when they are truly empty (no children, not terminal) - Separate deletion success from node pruning logic - Add regression test for prefix case (Hell/Hello)
sudheerxdev
requested review from
Panquesito7 and
realstealthninja
as code owners
- Replace direct git push with create-pull-request action - Fixes issue TheAlgorithms#2411: CI unable to push to master - PR-based approach is safer and aligns with GitHub best practices - CI now creates automatic PRs for formatting/linting fixes - Maintainers can review before merge
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes critical bug in trie deleteString function where child pointers were being unconditionally reset, corrupting words that share prefixes.
Changes
Testing